Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNF-13958: Enable TLS verification for in-cluster deployments #177

Conversation

alegacy
Copy link
Contributor

@alegacy alegacy commented Aug 20, 2024

This configures the TLS clients using the service account root CA bundles so that we can properly verify the identity of backend servers.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Aug 20, 2024

@alegacy: This pull request references CNF-13958 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.18.0" version, but no target version was set.

In response to this:

This configures the TLS clients using the service account root CA bundles so that we can properly verify the identity of backend servers.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

}

if data, err := os.ReadFile(defaultServiceCAFile); err != nil {
return fmt.Errorf("failed to read service CA rile '%s': %w", defaultServiceCAFile, err)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: rile

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, fixed.

This configures the TLS clients using the service account root CA
bundles so that we can properly verify the identity of backend servers.

Signed-off-by: Allain Legacy <[email protected]>
@alegacy alegacy force-pushed the fix/enable-in-cluster-tls-verification branch from 016b6ca to 1baa135 Compare August 20, 2024 14:43
Copy link
Collaborator

@donpenney donpenney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 20, 2024
@irinamihai
Copy link
Collaborator

/approve

Copy link

openshift-ci bot commented Aug 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: irinamihai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 21, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit dfea4bf into openshift-kni:main Aug 21, 2024
8 checks passed
tliu2021 pushed a commit to tliu2021/oran-o2ims-poc that referenced this pull request Aug 21, 2024
…ift-kni#177)

This configures the TLS clients using the service account root CA
bundles so that we can properly verify the identity of backend servers.

Signed-off-by: Allain Legacy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants